More cloud like#44
Open
TheBjoRedCraft wants to merge 14 commits intoversion/26.1from
Open
Conversation
…xecute functionalities
Contributor
There was a problem hiding this comment.
Pull request overview
Adds “cloud-like” network administration capabilities by introducing a Velocity /core command and Redis request/response hooks to remotely shut down services or execute commands on specific servers/proxies.
Changes:
- Added Velocity
/corecommand (with permission nodes) to inspect players/services and trigger remote shutdown/command execution. - Introduced Redis request/response infrastructure and new
SurfServerServicesuspend APIs forshutdownandexecuteCommand, with Paper/Velocity listener implementations. - Updated Paper-side player display name handling (join + LuckPerms recalculation), fixed microservice player-error request handling, and bumped project/plugin versions.
Reviewed changes
Copilot reviewed 27 out of 27 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/permission/PermissionList.kt | Adds centralized permission constants for the new Velocity /core command tree. |
| surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/listener/VelocityShutdownListener.kt | Implements shutdown handling for targeted proxy instances. |
| surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/listener/VelocityExecuteCommandListener.kt | Implements command execution handling for targeted proxy instances. |
| surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/command/CoreCommand.kt | Introduces the Velocity /core command with player/service subcommands and remote actions. |
| surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/VelocityMain.kt | Registers the new Velocity /core command on enable. |
| surf-core-velocity/build.gradle.kts | Ensures the Velocity plugin metadata includes the project version. |
| surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt | Sets player display name on join using a prefixed name helper. |
| surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PaperShutdownListener.kt | Adds shutdown handling for targeted backend servers. |
| surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PaperExecuteCommandListener.kt | Adds command execution handling for targeted backend servers. |
| surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/SurfCoreCommand.kt | Renames Paper command root from core to surfcore. |
| surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/NetworkBroadcastCommand.kt | Adjusts broadcast formatting to be more prominent (“INFO”) and adds spacing. |
| surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/PaperMain.kt | Subscribes to LuckPerms user recalculation events to refresh display names. |
| surf-core-microservice/src/main/kotlin/dev/slne/surf/core/microservice/rabbit/SurfPlayerErrorHandler.kt | Responds to save-error request packets with the saved error data. |
| surf-core-microservice/src/main/kotlin/dev/slne/surf/core/microservice/CoreMicroservice.kt | Ensures the player error table is included in schema creation. |
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/server/SurfServerService.kt | Extends server service API with suspend shutdown and executeCommand. |
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/redis/request/ShutdownServerRequest.kt | Adds Redis request/response model for remote shutdown. |
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/redis/request/ExecuteCommandServerRequest.kt | Adds Redis request/response model for remote command execution. |
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/redis/listener/ShutdownServerRedisListener.kt | Adds handler that routes shutdown requests to platform-specific listeners. |
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/redis/listener/ShutdownServerListener.kt | Introduces service-loaded interface for platform-specific shutdown behavior. |
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/redis/listener/ExecuteCommandServerListener.kt | Introduces service-loaded interface for platform-specific command execution. |
| surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/redis/listener/ExecuteCommandRedisListener.kt | Adds handler that routes execute-command requests to platform-specific listeners. |
| surf-core-core/surf-core-core-client/src/main/kotlin/dev/slne/surf/core/client/server/SurfServerServiceImpl.kt | Implements new SurfServerService methods by issuing Redis requests. |
| surf-core-core/surf-core-core-client/src/main/kotlin/dev/slne/surf/core/client/ClientLoader.kt | Registers the new Redis request/response handlers. |
| surf-core-api/surf-core-api-velocity/src/main/kotlin/dev/slne/surf/core/api/velocity/command/argument/SurfPlayerArgument.kt | Adds suggestion provider for online player names. |
| surf-core-api/surf-core-api-velocity/src/main/kotlin/dev/slne/surf/core/api/velocity/command/argument/SurfOfflinePlayerArgument.kt | Adds suggestion provider (currently based on online player names). |
| surf-core-api/surf-core-api-velocity/src/main/kotlin/dev/slne/surf/core/api/velocity/command/argument/SurfCommonServerArgument.kt | Adds suggestion provider for known common server names. |
| gradle.properties | Bumps snapshot version to 2.3.0-SNAPSHOT. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
twisti-dev
requested changes
May 6, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.